Add tournament
#347
Add tournament
#347
Conversation
BNAndras
added
x:module/practice-exercise
|
CI fails so I'll need to figure that part out. |
kotp
left a comment
kotp
left a comment
There was a problem hiding this comment.
Reviewed locally, looks good to me.
The original message still has this, probably better to use the "draft" setting here, maybe, rather than something that remails "static". So not quite sure what to do at the moment, other than ci failing still... |
|
Probably needs a rebase on origin/main, as when I check this out, there |
|
Those are the test input files. I didn’t touch any other files outside of the usual stuff for adding an exercise |
"wip", "beta", "active", and "deprecated" are the valid statuses, and wip is appropriate for having the exercise initially available for only maintainers, not students. |
Sorry, had interpreted "this" as the status of this patch, not "this" as the exercise. All good, we are on the same page. |
|
All twelve tests pass locally in 9.1.2050, but the test runner uses 9.1.1942 so there might be a hiccup there. |
Are we ready to update the test runner, then? |
|
I installed 9.1.1942 from source and all tests still passed. However, running the test runner image against the example still failed until I tweaked the sorting. 9.1.1942 is the latest in the alpine repos, but given that 9.1.1942 locally worked with the original solution, I don't think bumping vim in the test runner is the key. |
Can you describe in the commit message how the sorting was tweaked, so that the squash log will describe this as a bullet point? The sorting was only tweaked for the solution, as well, and not the tests, so that might be good to be able to immediately see in the message as well. |
2 participants
I'm leaving this exercise as
WIPstatus so we can double-check what this looks like with the 12 extra tabs (for the input files) in the online editor.At the moment, I'm not having the students write to a local file, but we probably could (or should) since the instructions refer to them also doing that. I suppose we could have them write the formatted output to a second folder so
inputs\01.txtgoes into theTallyfunction and the expected output will be inoutputs\01.txt.https://forum.exercism.org/t/adding-change-exercise/17766 (a conversation of exercises being added to vimscript).